Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring start & end dates into layer descriptions automatically #920

Merged
merged 28 commits into from
Jun 12, 2018
Merged

Bring start & end dates into layer descriptions automatically #920

merged 28 commits into from
Jun 12, 2018

Conversation

ZachTRice
Copy link
Contributor

@ZachTRice ZachTRice commented Apr 25, 2018 •
edited
Loading

Description

Fixes #384, Fixes #391, Fixes #424, Fixes #945, Fixes #1033, Fixes nasa-gibs/worldview-components#49
Connects to nasa-gibs/worldview-options-eosdis#187

  • Bring start/end dates into info dialog box
  • Fix data download bullets
  • Implement bootstrap 4 into wv (& fix css changes)
  • Implement reactstrap into wvc
  • Refactor layers css
  • Bring start/ end dates into search (worldview-components)
  • Rebase WVC onto the latest develop branch
  • Format date ranges in search results (worldview-components)
  • Add toggle functionality to show/hide date ranges in search (worldview-components)

Feedback Fixes:

  • Combine dates if start and end are the same.
    If layer.period === yearly then output just year.
    If layer.period === monthly then output just month + year
  • Fix range outputting wrong date (black marble reads 2017)

Feedback Fixes (round 2):
Things to fix:

  • Layer end date is building wrong:
    Example: Sea Surface Salinity (L3, 7-Day Snapshot, SAC-D, Aquarius)
    GC Doc: 2015-06-04/2015-06-04/P4D 4 days.
    Issue: This branch has end_date defined as June 4th, it should be June 8th. This means the build is not adding the interval to the end_date.

  • Temporal Range wrong:
    Example: 5 Year Tree Cover (CONUS, V1.5)
    Issue: Layer says "Temporal Range: 15 April 2006 - 15 April 2006"
    Should say "Temporal Range: 15 April 2006 to 17 November 2010" (i.e. account for 2006-04-15/2006-04-15/P1678D GC)

  • Latest end date in date range list does not say "Present"
    Example: Aerosol Index

  • Monthly date ranges do not have year (showing date + month) in search results
    Example: Carbon Monoxide (L3, Monthly, Night, Surface Mixing Ratio)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if appropriate)
  • I have added tests that prove my fix is effective or that my feature works
  • Lint and unit tests pass locally with my changes (npm run test)
  • Any dependent changes have been merged and published in downstream modules

Additional Information

nasa-gibs/worldview-options-eosdis#187 must be merged at the same time

@nasa-gibs/worldview

@ghost ghost assigned ZachTRice Apr 25, 2018
@ghost ghost added the under development label Apr 25, 2018
@ZachTRice ZachTRice force-pushed the start-end-dates-384 branch from 93ec828 to f82fc54 Compare April 25, 2018 16:06
This was referenced Apr 25, 2018
Closed
Closed
Closed
Closed
@ZachTRice ZachTRice force-pushed the start-end-dates-384 branch from fe04c4b to d81a4cc Compare May 30, 2018 02:02
@ZachTRice ZachTRice changed the title Bring start & end dates into layer descriptions automatically [WIP] Bring start & end dates into layer descriptions automatically May 30, 2018
@ZachTRice ZachTRice added this to the June Release milestone May 30, 2018
@ZachTRice ZachTRice force-pushed the start-end-dates-384 branch 3 times, most recently from 5e353e2 to 30cb636 Compare May 31, 2018 01:03
@ZachTRice ZachTRice requested a review from Benjaki2 June 1, 2018 15:10
Benjaki2
Benjaki2 approved these changes Jun 1, 2018
View reviewed changes
Copy link
Collaborator

@Benjaki2 Benjaki2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ZachTRice ZachTRice force-pushed the start-end-dates-384 branch 3 times, most recently from 5071a98 to 0f149a7 Compare June 1, 2018 19:12
@ZachTRice ZachTRice requested a review from minniewong June 4, 2018 19:32
@ZachTRice ZachTRice force-pushed the start-end-dates-384 branch from 61afa3e to 097290e Compare June 5, 2018 13:26
minniewong
minniewong requested changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@minniewong minniewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some outlying issues with layers with weird periods, e.g. monthly sea surface salinity (SAC-D/Aquarius) P1M should end at the end of the month not on 1 May 2015, same for P7D; 5 Year Tree Cover should display 2006 - 2010.

@ZachTRice ZachTRice force-pushed the start-end-dates-384 branch from 097290e to 2acbe31 Compare June 5, 2018 17:33
@ZachTRice ZachTRice force-pushed the start-end-dates-384 branch 3 times, most recently from 028ca74 to 73cadeb Compare June 8, 2018 14:09
ZachTRice added 2 commits June 11, 2018 09:13
@ZachTRice
Fix info window not closing when layer is removed
f346d11
@ZachTRice
Restructure layer CSS, add classes to layer elements, remove layer title
6f04f24 
- Combined layer.modal, layer.info, layer.options into one layers.css file
- Added classes to layer elements
- Removed ID selectors in layer.css
- Removed titles from info modal description area
- Added start / end date values to info modal description area
ZachTRice and others added 21 commits June 11, 2018 09:13
@ZachTRice
Add check for layer.dateRanges before outputting in info modal
876e165
@ZachTRice
Add Bootstrap v4 package and import bootstrap.css #424
3e76838
@ZachTRice
Fix elements affected by bootstrap implementation & rename classes #424
a38ac3f
@ZachTRice
Ensure PS updates when large date range is toggled
7eee34c
@ZachTRice
Adjust layer info classes and styles
7af1ce7
@ZachTRice
Close info dialog when layer removed & update sidebar & layers css
631bf19
@ZachTRice
Format view all layer button and style all date ranges box
31dffbf
@ZachTRice
Update metadata props
9cf795b
@ZachTRice
Fix layer endDate in build process and output formatted yearly & mont…
3abdfd7 
…hlydates
@ZachTRice
Account for all monthly and yearly range outputs
f21edce
@ZachTRice
Update components and options
77c51a0
@ZachTRice
Update e2e layer test
a2ddb28
@ZachTRice
Fix sidebar footer positioning
9a0b3d5
@ZachTRice
Format day date range if start & end are equal. Order dates descending
401731d
@ZachTRice
Fix end date building incorrectly
e717b1a
@ZachTRice
Add 'Present' to latest date range if there is no layer endDate
87cfc78
@ZachTRice
Add dateInterval to rangeEndDate in date ranges
b61e714
@ZachTRice
Add month to monthly conditional
644f2ab
@ZachTRice
Add month and year to daily date range
52ff774
@ZachTRice
Check if date ranges overlap
7f9aabc
@ZachTRice
Adjust sidebar panel css
6028999
@ZachTRice ZachTRice force-pushed the start-end-dates-384 branch from 06a3d5f to 6028999 Compare June 11, 2018 13:14
@ZachTRice ZachTRice mentioned this pull request Jun 11, 2018
Merged
5 tasks
@ZachTRice ZachTRice force-pushed the start-end-dates-384 branch from a733ff5 to 6eb4521 Compare June 11, 2018 21:27
@ZachTRice ZachTRice merged commit 04e5fdf into develop Jun 12, 2018
@ZachTRice ZachTRice deleted the start-end-dates-384 branch June 12, 2018 15:23
@ghost ghost removed the ready for review label Jun 12, 2018
@ZachTRice ZachTRice mentioned this pull request Jun 26, 2018
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjaki2 Benjaki2 Benjaki2 approved these changes

@minniewong minniewong minniewong approved these changes

Assignees

@ZachTRice ZachTRice

Labels
None yet
Projects
None yet
Milestone
June Release (v2.6.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@ZachTRice @Benjaki2 @minniewong