Fix style regressions #697
Conversation
ghost
assigned 
web/css/jquery-ui-override.css
Outdated
| @@ -1,6 +1,10 @@ | |||
| /* | |||
| * Default jquery-ui button | |||
| */ | |||
| .ui-button-text { | |||
| font-family: "Segoe UI", "Arial", sans-serif; | |||
There was a problem hiding this comment.
It looks like the original "Segoe UI" declaration is still there, it's just overridden by these two lines added in 8345cb1 that we could probably remove to be more efficient.
web/css/tour.css
Outdated
| .joyride-tip-guide.bordered span.joyride-nub.top::after { | ||
| top: -16px; | ||
| left: -15px; | ||
| border: 15px solid #808080 !important; |
There was a problem hiding this comment.
Are all of these !important declarations necessary? These are pretty specific selectors already.
There was a problem hiding this comment.
Actually, that's a good point. On the after elements, !important should not be needed. I will double-check and remove.
web/pages/tour.html
Outdated
| @@ -5,7 +5,7 @@ | |||
| <p class="splashwelcome"> | |||
| This application allows you to interactively browse global satellite imagery within hours of it being acquired. Use the features described below to find interesting imagery, save and share what you find, and download the underlying data. | |||
| </p> | |||
| <br> | |||
| <br><br> | |||
There was a problem hiding this comment.
I'm not quite sure what caused the extra spacing in production, but I think a single space is fine, and fits the rhythm of the page better. A double <br><br> seems unnecessary. What do you think about removing it?
There was a problem hiding this comment.
I agree, I added it back in for parity with what we had before.
ZachTRice
force-pushed
the
module-loaders-fix-style-regressions
branch
from
7933f55 to
ddfbc80
Compare
- Add "Segoe UI" default font back to "Add Layers" button - Change tour step 1 to be a wide window - Add `bordered` styles to tour windows which were removed from our version of joyride; this requires using an after element on the `nub` element whereas before there was a second element. - Fix margins in tour windows - Remove `minimal-ui` viewport attribute Connects to #671, Connects to #670
ZachTRice
force-pushed
the
module-loaders-fix-style-regressions
branch
from
ddfbc80 to
739e335
Compare
Fixes #670, Fixes #671
Changes in this pull request:
borderedstyles to tour windows which were removed from our version of joyride;this requires using an after element on the
nubelement whereas before there was a second element.minimal-uiviewport attribute