Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix babel polyfills not working in IE and older browsers #665

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

ZachTRice
Copy link
Contributor

  • Add babel-polyfill import to main.js

@ghost ghost assigned ZachTRice Jan 11, 2018
@ghost ghost added the under development label Jan 11, 2018
@ZachTRice ZachTRice requested review from localjo and Benjaki2 January 11, 2018 21:24
Copy link
Contributor

@localjo localjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

web/js/main.js Outdated
@@ -1,3 +1,4 @@
import 'babel-polyfill';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a comment on this line that explains why we need to import it;

import 'babel-polyfill'; // Needed for worldview-components in IE and older browsers

- Add babel-polyfill import to main.js
@ZachTRice ZachTRice force-pushed the module-loaders-polyfill branch from b259fe1 to 6dcd32d Compare January 11, 2018 21:29
Copy link
Collaborator

@Benjaki2 Benjaki2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ZachTRice ZachTRice merged commit eb0799c into module-loaders Jan 11, 2018
@ghost ghost removed the under development label Jan 11, 2018
@ZachTRice ZachTRice deleted the module-loaders-polyfill branch January 11, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants