Modularize mobile timeline wheel #651
Conversation
ghost
assigned 
localjo
force-pushed
the
modularize-mobile-timeline
branch
from
56f5501 to
5bc99f0
Compare
There was a problem hiding this comment.
While using the timewheel I am seeing Uncaught TypeError: Cannot read property 'classList' of null
I'm having trouble finding a consistent way to reproduce the error.
It seems I see it when I open the timeline wheel, drag the viewport window, then open the timewheel again and change the dates. It's strange too because the wheel seems to glitch out and allow for the left/right keyboard arrows to control the date and at this point then every time I use the arrows to change the date, I see the arrow.
I am also able to see this happen via browserstack (S8 Chrome). I open timeline wheel, then change the orientation, then open timewheel again and change the data. The same glitch with the arrows happens and I see the console arrows.
Note: The most consistent way to reproduce the error seems to be to use browserstack, open timewheel, change orientation, use left/right arrow keys to change the date.
I tried reproducing this on the main app to make sure it wasn't happening there as well but I wasn't able to reproduce it.
localjo
force-pushed
the
modularize-mobile-timeline
branch
from
9e152f9 to
328bc83
Compare
localjo
force-pushed
the
module-loaders
branch
from
ccb0715 to
fd92918
Compare
localjo
force-pushed
the
modularize-mobile-timeline
branch
from
328bc83 to
294c77f
Compare
The newer version of mobiscroll requires a license to access full functionality, so we need to stick with the old version until we can replace this dependency
localjo
force-pushed
the
modularize-mobile-timeline
branch
from
294c77f to
c4dd053
Compare
|
I can't reproduce that error. @ZachTRice Are you seeing the timeline wheel appear on desktop? I wouldn't think it works on desktop. And what arrows are you using to change the date on mobile? I'm not seeing any arrows. |
|
Yeah, the timewheel appears on the responsive desktop view when you click the date in the corner. |
|
Note: I am only able to reproduce this when the source is minified. |
| @@ -89,3 +89,5 @@ export function dateWheels(models, config) { | |||
| init(); | |||
| return self; | |||
| }; | |||
|
|
|||
| export default dateWheels; | |||
There was a problem hiding this comment.
@localjo what's the reason for making this a default export instead of exporting the function?
There was a problem hiding this comment.
dateWheels is a function. These two are more or less equivalent;
export default function(){};
And
var dateWheels = function(){};
export default dateWheels;
I don't remember exactly why I did it this way here. Probably just to be clearer by giving a name to what I was exporting.
Based on
update-build-scripts(#647)Modularizes mobile timeline wheel. Had to revert
mobiscrollto 2.6.x and put it back in the/web/extdirectory. The newer version of mobiscroll requires a license to access full functionality, so we need to stick with the old version until we can replace this dependency.This PR also fixes various mobile bugs.