Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize notification feature #644

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Modularize notification feature #644

merged 1 commit into from
Jan 3, 2018

Conversation

Benjaki2
Copy link
Collaborator

@Benjaki2 Benjaki2 commented Dec 22, 2017 •
edited
Loading

Updates

  • Uses module loaders import necessary dependencies
  • Activates info button and updates function name from info to uiInfo

Dependent on other PRs

Dependent on other commits in other PRs to be pulled into module-loaders branch

@ghost ghost assigned Benjaki2 Dec 22, 2017
@ghost ghost added the under development label Dec 22, 2017
@Benjaki2 Benjaki2 requested review from localjo and removed request for localjo December 22, 2017 17:33
localjo
localjo approved these changes Dec 26, 2017
View reviewed changes
Copy link
Contributor

@localjo localjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Benjaki2 Benjaki2 mentioned this pull request Jan 2, 2018
Merged
58 tasks
Modularize notification feature
7ff1d4a 
* Rename function to notificationsUi
* Rename function from info to uiInfo
* Use module loaders import necessary dependencies
@Benjaki2 Benjaki2 force-pushed the module-loaders-notifications branch from 12710a8 to 7ff1d4a Compare January 3, 2018 21:20
@Benjaki2 Benjaki2 merged commit db96b48 into module-loaders Jan 3, 2018
@Benjaki2 Benjaki2 deleted the module-loaders-notifications branch January 3, 2018 21:37
@ghost ghost removed the under development label Jan 3, 2018
@localjo localjo added this to the Module Loaders Release (v2.0) milestone Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localjo localjo localjo approved these changes

@ZachTRice ZachTRice ZachTRice approved these changes

Assignees

@Benjaki2 Benjaki2

Labels
None yet
Projects
None yet
Milestone
Module Loaders Release (v2.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@Benjaki2 @localjo @ZachTRice