Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module loaders work #494

Closed
minniewong opened this issue Aug 31, 2017 · 0 comments
Closed

Module loaders work #494

minniewong opened this issue Aug 31, 2017 · 0 comments
Assignees

Comments

@minniewong
Copy link
Contributor

minniewong commented Aug 31, 2017

Our final solution should meet the following criteria:

  • We should have the ability to use ES6 syntax in all of our app files
  • All of our app files should be imported and not use global variables
    • Forces us to decouple our modules and stick to consistent design patterns
    • Allows us to eliminate dead code
  • All dependencies should be imported where used, and not assigned to global variables
    • Gives visibility into where dependencies are used
      Allows us to remove or replaces dependencies when needed
  • All scripts should be bundled into "app" and "vendor" bundles
    • Reduces the number of HTTP requests
    • Allows us to cache dependencies and app code separately
    • Allows us to apply minification and other transforms to all scripts
  • We should have a manifest of all of our dependencies in package.json
    • Provides a record for ourselves and contributors to know which dependencies are being used
    • Allows us to use tools to analyze and optimize our dependency graph
    • Allows us to apply security updates, bug fixes and new features from our dependencies quickly
    • Reduces the amount of third party code committed to our repo
Benjaki2 pushed a commit that referenced this issue Sep 6, 2017
Benjaki2 pushed a commit that referenced this issue Sep 7, 2017
Benjaki2 pushed a commit that referenced this issue Sep 7, 2017
Benjaki2 pushed a commit that referenced this issue Sep 7, 2017
@Benjaki2 Benjaki2 mentioned this issue Sep 7, 2017
58 tasks
@minniewong minniewong added this to the Release 1.11.0 milestone Nov 1, 2017
@minniewong minniewong removed this from the Release 1.11.0 milestone Dec 8, 2017
@localjo localjo added this to the Module Loaders Release (v2.0) milestone Jan 12, 2018
@localjo localjo mentioned this issue Jan 22, 2018
5 tasks
@ghost ghost removed the testing label Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants