Skip to content
This repository was archived by the owner on Nov 16, 2018. It is now read-only.

Immutable palettes #220

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Immutable palettes #220

merged 2 commits into from
Jul 24, 2018

Conversation

mike-mcgann
Copy link
Collaborator

Description

Fixes nasa-gibs/worldview#1109.

Added "immutable" parameter to:

  • Landsat_WELD_CONUS_5_Year_Tree_Cover

Any other layers that should be added?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if appropriate)
  • I have added tests that prove my fix is effective or that my feature works
  • Lint and unit tests pass locally with my changes (npm run test)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, start a discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@nasa-gibs/worldview

@ghost ghost assigned mike-mcgann Jul 13, 2018
@ghost ghost added the under development label Jul 13, 2018
@mike-mcgann mike-mcgann requested a review from minniewong July 13, 2018 13:52
Copy link
Contributor

@minniewong minniewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When I load WELD Tree cover, the legend is present, if I click around a lot on that layer in the layer list, the colorbar legend disappears.
  2. We might want to move WELD Tree cover to "overlays" instead of keeping it at "baselayers" - thoughts?

@mike-mcgann
Copy link
Collaborator Author

Actually, I think it needs to be an overlay. As a baselayer, the map will ignore everything below it since it assumes baselayers cover the full extent and are opaque. Changed to overlay.

For item 1, I was able to generate that bug simply by trying to move the layer. Making it an overlay solved the problem. Something in the code might assume colorbars are not allowed for baselayers.

@ZachTRice ZachTRice added this to the July Release milestone Jul 24, 2018
@mike-mcgann mike-mcgann merged commit b86da14 into develop Jul 24, 2018
@ghost ghost removed the under development label Jul 24, 2018
@ZachTRice ZachTRice mentioned this pull request Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants