Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Browser breadcrumb links are not pointing to the correct paths #1721

Closed
dakota002 opened this issue Dec 5, 2023 · 5 comments · Fixed by #1727
Closed

Schema Browser breadcrumb links are not pointing to the correct paths #1721

dakota002 opened this issue Dec 5, 2023 · 5 comments · Fixed by #1727
Assignees
Labels
bug Something isn't working frontend Issue relates to front-end development (react-uswds widgets)

Comments

@dakota002
Copy link
Contributor

image

The paths seem to be parsing the .. filled array relative to the base path of /docs/schema/{version}, and not the full path of /docs/schema/{version}/*

@lpsinger
Copy link
Member

lpsinger commented Dec 5, 2023

I thought that I added the relative="path" attribute to fix this some time ago. Perhaps there has been a regression in Remix or react-router.

@lpsinger
Copy link
Member

lpsinger commented Dec 5, 2023

Yup, I think that this broke when we updated from remix 2.2.0 to 2.3.0.

@lpsinger
Copy link
Member

lpsinger commented Dec 5, 2023

I've reviewed the diff between Remix 2.2.0 and 2.3.0 and it looks pretty boring. On the other hand, there are some relevant looking changes in the following two dependencies that were updated in that version:

@lpsinger
Copy link
Member

lpsinger commented Dec 5, 2023

Possibly remix-run/react-router#11006...

@lpsinger
Copy link
Member

lpsinger commented Dec 5, 2023

Yup, this was broken by the fix of remix-run/react-router#10998.

@lpsinger lpsinger added bug Something isn't working frontend Issue relates to front-end development (react-uswds widgets) labels Dec 7, 2023
@lpsinger lpsinger self-assigned this Dec 7, 2023
lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this issue Dec 7, 2023
lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this issue Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Issue relates to front-end development (react-uswds widgets)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants