feat: Add support for series[other_series]
#2013
Conversation
There was a problem hiding this comment.
Moved all the __getitem__ tests previously in slice_test.py
| @@ -156,7 +159,9 @@ def __getitem__(self: Self, idx: int | slice | Sequence[int]) -> Any | Self: | |||
| is_numpy_scalar(idx) and idx.dtype.kind in ("i", "u") | |||
| ): | |||
| return self._compliant_series[idx] | |||
| return self._from_compliant_series(self._compliant_series[idx]) | |||
| return self._from_compliant_series( | |||
| self._compliant_series[to_native(idx, pass_through=True)] | |||
There was a problem hiding this comment.
Kind of unrelated, but we have a method called _extract_native which actually (maybe) extracts compliant 🙈
There was a problem hiding this comment.
that's an awfully good point
dangotbanned
changed the title
series[other_series]series[other_series]
|
Took me 10 seconds to figure out what changed 😁 thanks a ton 🤩 |
FBruzzesi
added
the
high priority
| @@ -156,7 +159,9 @@ def __getitem__(self: Self, idx: int | slice | Sequence[int]) -> Any | Self: | |||
| is_numpy_scalar(idx) and idx.dtype.kind in ("i", "u") | |||
| ): | |||
| return self._compliant_series[idx] | |||
| return self._from_compliant_series(self._compliant_series[idx]) | |||
| return self._from_compliant_series( | |||
| self._compliant_series[to_native(idx, pass_through=True)] | |||
There was a problem hiding this comment.
that's an awfully good point
| @pytest.mark.filterwarnings( | ||
| "ignore:.*_array__ implementation doesn't accept a copy keyword.*:DeprecationWarning:modin" | ||
| ) |
There was a problem hiding this comment.
is this just something that Modin calls (on itself?) internally? not anything we need to concern ourselves with?
There was a problem hiding this comment.
Yes, it traces back to modin/pandas/indexing.py
There was a problem hiding this comment.
Reviewing from my phone but should be good thanks @FBruzzesi !
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below