Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pandas-stubs issues #2008

Merged
merged 17 commits into from
Feb 17, 2025
Merged

chore: fix pandas-stubs issues #2008

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
cbb0669
chore: fix pandas-stubs issues
MarcoGorelli Feb 13, 2025
1a2e5f3
fix
MarcoGorelli Feb 13, 2025
9c486da
fix
MarcoGorelli Feb 13, 2025
1960fc2
fx
MarcoGorelli Feb 13, 2025
bd80c9c
Merge remote-tracking branch 'upstream/main' into pandas-typing-issues
MarcoGorelli Feb 14, 2025
b372a12
remove from mypy overrides
MarcoGorelli Feb 14, 2025
6b8047a
Merge branch 'main' into pandas-typing-issues
MarcoGorelli Feb 15, 2025
66f7b0d
Merge remote-tracking branch 'upstream/main' into pr/MarcoGorelli/2008
dangotbanned Feb 17, 2025
d4d8d39
fix typing tests
dangotbanned Feb 17, 2025
7cf8e73
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 17, 2025
7152492
fix(typing): avoid `TypeVar` in tests
dangotbanned Feb 17, 2025
c711332
remove unused ignores
dangotbanned Feb 17, 2025
bad8f97
fix(DRAFT): maybe detect `"numpy_nullable"` w/ public api
dangotbanned Feb 17, 2025
a4dc352
test: resolve most of the new warnings
dangotbanned Feb 17, 2025
6a78fc9
test: resolve remaining warnings
dangotbanned Feb 17, 2025
bb5665c
fix(typing): resolve `polars` warning
dangotbanned Feb 17, 2025
269fdb4
Merge branch 'main' into pandas-typing-issues
dangotbanned Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion narwhals/_pandas_like/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,11 @@ def get_dtype_backend(dtype: Any, implementation: Implementation) -> DTypeBacken
if hasattr(pd, "ArrowDtype") and isinstance(dtype, pd.ArrowDtype):
return "pyarrow"
with suppress(AttributeError):
if isinstance(dtype, pd.core.dtypes.dtypes.BaseMaskedDtype):
sentinel = object()
if (
isinstance(dtype, pd.api.extensions.ExtensionDtype)
and getattr(dtype, "base", sentinel) is None
):
Comment on lines +515 to +519
Copy link
Member

@dangotbanned dangotbanned Feb 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to avoiding pd.core (#2008 (comment))

Available since 0.23.0

Pretty sure we don't need with suppress(AttributeError): with this?
@MarcoGorelli

return "numpy_nullable"
return None

Expand Down
Loading