feat: support more scalar operations for duckdb, Increase width for ipython #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Jan 27, 2025
Comment on lines
-1038
to
+1042
| terminal_width = 80 | ||
| terminal_width = int(os.getenv("COLUMNS", 80)) # noqa: PLW1508 | ||
| native_lines = native_repr.splitlines() | ||
| max_native_width = max(len(line) for line in native_lines) | ||
|
|
||
| if max_native_width + 2 < terminal_width: | ||
| if max_native_width + 2 <= terminal_width: |
There was a problem hiding this comment.
drive-by, but i noticed that on kaggle notebooks os.get_terminal_size() raises, but COLUMNS is set to 100. COLUMNS seems to be the IPython standard
MarcoGorelli
commented
Jan 27, 2025
|
uurghh gonna have to come back to this |
|
🤔 we might need |
|
just jotting down some thoughts:
n-ary operation between expressions:
select:
with_columns:
|
MarcoGorelli
commented
Jan 27, 2025
| DUCKDB_SKIPS = ["q14", "q15"] | ||
| DUCKDB_SKIPS = ["q15"] |
FBruzzesi
approved these changes
Jan 27, 2025
| # it means that it was a scalar (e.g. nw.col('a') + 1), and so we default | ||
| # to `True`. | ||
| return lhs._returns_scalar and getattr(rhs, "_returns_scalar", True) | ||
| def n_ary_operation_expr_kind(*args: DuckDBExpr | Any) -> ExprKind: |
narwhals/_duckdb/utils.py
Outdated
Comment on lines
23
to
24
| class ExprKind(Enum): | ||
| LITERAL = auto() # e.g. nw.lit(1) |
There was a problem hiding this comment.
Might be worth adding a tiny docstring and describe interaction between values:
Suggested change
| class ExprKind(Enum): | |
| LITERAL = auto() # e.g. nw.lit(1) | |
| class ExprKind(Enum): | |
| """Describe which kind of expression we are dealing with. | |
| Composition rule is: | |
| - LITERAL & LITERAL -> LITERAL | |
| - TRANSFORM & X -> TRANSFORM | |
| - X & TRANSFORM -> TRANSFORM | |
| - all remaining cases -> AGGREGATION | |
| """ | |
| LITERAL = auto() # e.g. nw.lit(1) |
|
thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to the recent PySpark PR #1870
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below