Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor name namespaces to lower code duplication #1876

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

FBruzzesi
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @FBruzzesi ! we can probably add a few more too (e.g. to_titlecase)

@FBruzzesi FBruzzesi merged commit 9b6a355 into main Jan 27, 2025
23 checks passed
@FBruzzesi FBruzzesi deleted the chore/name-namespace-refactor branch January 27, 2025 16:00
@FBruzzesi
Copy link
Member Author

nice, thanks @FBruzzesi ! we can probably add a few more too (e.g. to_titlecase)

Am I missing something from the polars docs?

@MarcoGorelli
Copy link
Member

ah sorry they have [polars.Expr.str.to_titlecase](https://docs.pola.rs/api/python/dev/reference/expressions/api/polars.Expr.str.to_titlecase.html)

but we could add the selector anyway and be one step ahead πŸ˜„

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants