Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow any name in expression parsing #1871

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

FBruzzesi
Copy link
Member

Currently if we do:

@nw.narwhalify
def func(df):
    return df.with_columns(df=nw.col("a")+1)

with any backend except polars, we get an error:

TypeError: evaluate_into_exprs() got multiple values for argument 'df'

This PR fixes this issue

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you win an award for spotting this 🏆

@MarcoGorelli MarcoGorelli merged commit a851b13 into main Jan 26, 2025
23 of 24 checks passed
@MarcoGorelli MarcoGorelli deleted the fix/expression-parsing-with-any-column-name branch January 26, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants