-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: completely refactor alias tracking and support nw.all
, nw.nth
, and selectors across the API
#1866
feat: completely refactor alias tracking and support nw.all
, nw.nth
, and selectors across the API
#1866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing stuff! I tried to review one lazy and one eager backend in depth, and then assumed that the same changes apply to all others - I also re-watched the live streaming to get a better high level understanding of it!
I was expecting to see some other tests to XPASS for pyspark, I will try them locally later today!
As a bonus, I think there could be a good opportunity to factor out name namespace and selectors, but definitly let's do it in another PR.
thanks @FBruzzesi !
I think we need a further refactor for that to happen, so that we only use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a couple of list comprehensions
https://youtu.be/0JGpveomN9A
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below