Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: completely refactor alias tracking and support nw.all, nw.nth, and selectors across the API #1866

Merged
merged 43 commits into from
Jan 26, 2025

Conversation

MarcoGorelli
Copy link
Member

https://youtu.be/0JGpveomN9A

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff! I tried to review one lazy and one eager backend in depth, and then assumed that the same changes apply to all others - I also re-watched the live streaming to get a better high level understanding of it!

I was expecting to see some other tests to XPASS for pyspark, I will try them locally later today!

As a bonus, I think there could be a good opportunity to factor out name namespace and selectors, but definitly let's do it in another PR.

narwhals/_dask/expr.py Outdated Show resolved Hide resolved
narwhals/_dask/expr.py Outdated Show resolved Hide resolved
narwhals/_dask/selectors.py Show resolved Hide resolved
tests/group_by_test.py Outdated Show resolved Hide resolved
@MarcoGorelli
Copy link
Member Author

thanks @FBruzzesi !

I was expecting to see some other tests to XPASS for pyspark, I will try them locally later today!

I think we need a further refactor for that to happen, so that we only use .over when absolutely necessary

@MarcoGorelli MarcoGorelli added the enhancement New feature or request label Jan 26, 2025
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple of list comprehensions

narwhals/_spark_like/expr.py Outdated Show resolved Hide resolved
narwhals/_duckdb/expr.py Outdated Show resolved Hide resolved
@MarcoGorelli MarcoGorelli marked this pull request as ready for review January 26, 2025 13:35
@MarcoGorelli MarcoGorelli merged commit a585548 into narwhals-dev:main Jan 26, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants