Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix api completness generation in CI #1863

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

FBruzzesi
Copy link
Member

@FBruzzesi FBruzzesi commented Jan 24, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

If you have comments or can explain your changes, please do so below

I was wonder how this happened - how pyspark and dask disappeared - and I assumed it's due to the fact that with imports on top of the file, we cannot run the modules to inspect classes safely.

We might want to use uv and caching this as well - pyspark and dask are a bit heavier

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@MarcoGorelli MarcoGorelli merged commit e2ba74b into main Jan 26, 2025
22 of 24 checks passed
@MarcoGorelli MarcoGorelli deleted the docs/fix-api-completeness branch January 26, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants