Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: downstream test for formulaic #1817

Merged
merged 14 commits into from
Jan 17, 2025

Conversation

luke396
Copy link
Member

@luke396 luke396 commented Jan 16, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luke396 πŸš€

I think it is just missing a tiny command πŸ™ƒ

.github/workflows/downstream_tests.yml Outdated Show resolved Hide resolved
@luke396
Copy link
Member Author

luke396 commented Jan 16, 2025

It works fine locally with act, possibly due to cachingβ€”still investigating.

@MarcoGorelli MarcoGorelli changed the title ci: downstream test for formulatic ci: downstream test for formulaic Jan 16, 2025
@luke396
Copy link
Member Author

luke396 commented Jan 17, 2025

CI is green.

Apologies for formatting the entire file due to my lack of proficiency with nvim. If necessary, I’d be happy to revert the changes.

@luke396 luke396 requested a review from FBruzzesi January 17, 2025 04:21
@FBruzzesi FBruzzesi added the ci label Jan 17, 2025
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing effort! Thanks @luke396

UpVoteDownVoteGIF

@FBruzzesi FBruzzesi merged commit f0e82cb into narwhals-dev:main Jan 17, 2025
23 of 24 checks passed
@luke396 luke396 deleted the add-test-formulatic branch January 17, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: add formulaic to downstream tests
3 participants