feat: add duckdb dataframe drop_nulls
#1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Jan 14, 2025
FBruzzesi
commented
Jan 14, 2025
MarcoGorelli
approved these changes
Jan 16, 2025
| @@ -107,7 +107,8 @@ def with_row_index(self, name: str = "index") -> Self: | |||
| self._compliant_frame.with_row_index(name), | |||
| ) | |||
|
|
|||
| def drop_nulls(self: Self, subset: str | list[str] | None = None) -> Self: | |||
| def drop_nulls(self: Self, subset: str | list[str] | None) -> Self: | |||
There was a problem hiding this comment.
wait I think it's fine for narwhals.DataFrame.drop_nulls to default to None? so users can just call df.drop_nulls()
There was a problem hiding this comment.
This is the BaseFrame implementation, the default still remains in DataFrame and LazyFrame and are passed along
There was a problem hiding this comment.
oops sorry! all good then 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Checklist
If you have comments or can explain your changes, please do so below