chore: simplify definitions of rhs expressions, bump dask minimum to 2024.10 #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Jan 4, 2025
Comment on lines
-25
to
+30
| def extract_compliant(expr: Expr, other: Any) -> Any: | ||
| def extract_compliant( | ||
| plx: CompliantNamespace[CompliantSeriesT_co], other: Any | ||
| ) -> CompliantExpr[CompliantSeriesT_co] | CompliantSeriesT_co | Any: |
There was a problem hiding this comment.
lol the annotations weren't right to begin with here 😄
MarcoGorelli
commented
Jan 4, 2025
Comment on lines
-1791
to
+1809
| other = extract_compliant(self, other) | ||
| return self.__class__(lambda plx: self._to_compliant_expr(plx).is_in(other)) | ||
| return self.__class__( | ||
| lambda plx: self._to_compliant_expr(plx).is_in( | ||
| extract_compliant(plx, other) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
this wasn't quite right to begin with (plx should be passed to extract_compliant, not self) - mypy helped detect it 😍
MarcoGorelli
force-pushed
the
simplify-rhs
branch
from
8e013f1 to
89597a0
Compare
MarcoGorelli
changed the title
MarcoGorelli
commented
Jan 5, 2025
| python-version: ["3.9", "3.11", "3.13"] | ||
| python-version: ["3.11", "3.13"] |
There was a problem hiding this comment.
we've already got other jobs testing 3.9 (like the "random versions" one)
MarcoGorelli
commented
Jan 5, 2025
Comment on lines
-85
to
-88
| request: pytest.FixtureRequest, | ||
| ) -> None: | ||
| if "dask_lazy_p2" in str(constructor) and "lit_with_agg" in col_name: | ||
| request.applymarker(pytest.mark.xfail) |
There was a problem hiding this comment.
feels nice to accidentally fix a bug with a refactor 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was quite satisfying 😋 I'm tired of reimplementing right-hand-side arithmetic for each backend, I think we can just do it at the
narwhals.ExprlevelWhat type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below