docs: let nw.LazyFrame docstrings examples run on Polars and Dask only
#1700
Conversation
AlessandroMiola
added
the
documentation
narwhals/dataframe.py
Outdated
| >>> agnostic_with_row_index(lf_dask).compute() | ||
| a b index | ||
| 0 1 4 0 | ||
| 1 2 5 1 | ||
| 2 3 6 2 |
There was a problem hiding this comment.
Should we try to adjust it so that index comes first?
There was a problem hiding this comment.
hmm well-spotted! i've opened an issue about it: #1703
There was a problem hiding this comment.
Let's just wait for #1706 to be merged first, then we can merge this one as well 🙌🏼
AlessandroMiola
force-pushed
the
docs-lf-polars-dask-examples-only
branch
from
d50b3e1 to
e65d115
Compare
narwhals/dataframe.py
Outdated
| >>> agnostic_with_row_index(lf_dask).compute() | ||
| a b index | ||
| 0 1 4 0 | ||
| 1 2 5 1 | ||
| 2 3 6 2 |
There was a problem hiding this comment.
hmm well-spotted! i've opened an issue about it: #1703
There was a problem hiding this comment.
Amazing work! Thanks a ton @AlessandroMiola
I wonder if we should .collect() within the agnostic functions so that we don't need to differentiate between compute and collect externally. Just a thought 🤔 Any opinions on it?
Thanks @FBruzzesi! |
AlessandroMiola
force-pushed
the
docs-lf-polars-dask-examples-only
branch
from
faac923 to
6674af0
Compare
There was a problem hiding this comment.
seriously awesome, thanks @AlessandroMiola and @FBruzzesi for reviewing!
| >>> lf | ||
| ┌───────────────────────────────────┐ | ||
| | Narwhals LazyFrame | | ||
| |-----------------------------------| | ||
| |Dask DataFrame Structure: | | ||
| | a b c| | ||
| |npartitions=2 | | ||
| |0 string int64 int64| | ||
| |3 ... ... ...| | ||
| |5 ... ... ...| | ||
| |Dask Name: frompandas, 1 expression| | ||
| |Expr=df | | ||
| └───────────────────────────────────┘ |
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below
Runs
nw.LazyFramedocstrings examples on Polars and Dask only.