Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more args and returns documentation in DataFrame class #1600

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

marenwestermann
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

I keep chipping away at this. :)

kwargs: Keyword arguments to pass to function.

Returns:
Self. The original object with the function applied.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need Self, the type annotation already shows up in the docs

@marenwestermann marenwestermann changed the title docs: [WIP] more args and returns documentation in DataFrame class docs: more args and returns documentation in DataFrame class Dec 19, 2024
@marenwestermann
Copy link
Contributor Author

I addressed the comment and finished the documentation for the Dataframe class. As a number of methods just return Self I think it wasn't really necessary to document what gets returned in these but I did it for consistency and also because I think it adds a bit of clarification in some places.

But anyway, let me know what you think. I don't feel super confident about the documentation.

@marenwestermann marenwestermann added the documentation Improvements or additions to documentation label Dec 19, 2024
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay thanks @marenwestermann !

@MarcoGorelli MarcoGorelli merged commit dfc91a4 into narwhals-dev:main Dec 19, 2024
25 checks passed
@MarcoGorelli
Copy link
Member

As a number of methods just return Self I think it wasn't really necessary to document what gets returned

the advantage of having at least something is that then it shows up in the rendered docs - I think simple phrases like the ones you've added are all that's needed πŸ‘

@marenwestermann marenwestermann deleted the more-dataframe-docs branch December 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants