Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename _expr to _compliant_expr in PandasLikeExpr #1527

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

olp-cs
Copy link
Contributor

@olp-cs olp-cs commented Dec 6, 2024

Renamed _expr to _compliant_expr in the following classes:

  • PandasLikeExprCatNamespace
  • PandasLikeExprDateTimeNamespace
  • PandasLikeExprStringNamespace
  • PandasLikeExprNameNamespace

What type of PR is this?

  • 💾 Refactor

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

Testing: No changes in tests results

pytest —vvl

before:
5113 passed, 64 skipped, 168 xfailed in 27.37s

after:
5113 passed, 64 skipped, 168 xfailed in 27.27s

Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @olp-cs it looks great 🚀!

DogHighFiveGIF

@MarcoGorelli
Copy link
Member

thanks @olp-cs ! if you fancied doing this for Arrow / Dask / others too, it'd be more than welcome!

@MarcoGorelli MarcoGorelli merged commit 0ca2755 into narwhals-dev:main Dec 7, 2024
24 checks passed
@olp-cs olp-cs deleted the 1499_compliant_expr branch December 8, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants