Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: _pandas_series to _compliant_series in PandasSeries #1517

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

skritsotalakis
Copy link
Contributor

Related issues

In _series, attribute _pandas_series was renamed to _compliant_series for the following classes:

PandasLikeSeriesCatNamespace
PandasLikeSeriesDateTimeNamespace
PandasLikeSeriesStringNamespace
PandasLikeExprCatNamespace
PandasLikeExprDateTimeNamespace
PandasLikeExprStringNamespace
PandasLikeExprNameNamespace
ArrowSeriesCatNamespace
ArrowSeriesDateTimeNamespace
ArrowSeriesStringNamespace
ArrowExprCatNamespace
ArrowExprDateTimeNamespace
ArrowExprStringNamespace
ArrowExprNameNamespace
PolarsSeriesCatNamespace
PolarsSeriesDateTimeNamespace
PolarsSeriesStringNamespace
PolarsExprCatNamespace
PolarsExprDateTimeNamespace
PolarsExprStringNamespace
PolarsExprNameNamespace
DaskExprCatNamespace
DaskExprDateTimeNamespace
DaskExprStringNamespace
DaskExprNameNamespace

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @skritsotalakis !

@MarcoGorelli MarcoGorelli merged commit 7447ee8 into narwhals-dev:main Dec 6, 2024
24 checks passed
@FBruzzesi FBruzzesi changed the title chore: in _series renamed _pandas_series to _compliant_series chore: _pandas_series to _compliant_series in PandasSeries Dec 6, 2024
@skritsotalakis
Copy link
Contributor Author

Cheers!
I will do the PandasLikeExprCatNamespace renaming next so #1499 can be closed

@MarcoGorelli
Copy link
Member

thanks! it wouldn't quite close the issue because the arrow / dask / etc ones would need the same treatment

@skritsotalakis skritsotalakis deleted the local_dev branch December 6, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants