Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add documentation for LazyGroupBy #1423

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

marenwestermann
Copy link
Contributor

@marenwestermann marenwestermann commented Nov 22, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

I saw that LazyGroupBy was not documented so I did it. Let me know if there are mistakes or if you would like changes.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 22, 2024
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @marenwestermann ! I'm embarassed that we forgot this one 😳

@MarcoGorelli MarcoGorelli merged commit 8901ec3 into narwhals-dev:main Nov 22, 2024
23 checks passed
@marenwestermann marenwestermann deleted the lazy-groupby-docs branch November 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants