Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update InvalidIntoExprError to mention nw.lit #1393

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

EdAbati
Copy link
Collaborator

@EdAbati EdAbati commented Nov 17, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome hint, I think users will appreciate this

just made some minor formatting changes

@MarcoGorelli MarcoGorelli merged commit 39cfb07 into narwhals-dev:main Nov 17, 2024
22 checks passed
@EdAbati EdAbati deleted the hint-update-intoexpr-error branch November 17, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants