chore: cleanup tpch execute #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdAbati
commented
Nov 13, 2024
| CUSTOMER_PATH = DATA_DIR / "customer.parquet" | ||
|
|
||
| BACKEND_READ_FUNC_MAP = { | ||
| # "pandas": lambda x: pd.read_parquet(x, engine="pyarrow"), # noqa: ERA001 |
There was a problem hiding this comment.
should we just remove these? I kept them because they were still in the dictionary
EdAbati
commented
Nov 13, 2024
| result.returncode == 0 | ||
| ), f"Script {script_path} failed with error: {result.stderr}" | ||
|
|
||
| @pytest.mark.parametrize("query_path", QUERIES_DIR.glob("q[1-9]*.py")) |
There was a problem hiding this comment.
if this PR doesn't get merged, I think that at least we should have this parametrised :)
FBruzzesi
reviewed
Nov 14, 2024
| result.returncode == 0 | ||
| ), f"Script {script_path} failed with error: {result.stderr}" | ||
|
|
||
| @pytest.mark.parametrize("query_path", QUERIES_DIR.glob("q[1-9]*.py")) |
MarcoGorelli
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
Inspired by #1348, I thought it would be handy if adding/removing backends from TPCH was a bit easier. With this change, adding/removing a key in the
BACKEND_READ_FUNC_MAPdictionary would add/remove a backend from the test.While refactoring this I found some duplicated (a path was present twice) and unused code (the read functions that I commented out). I hope that with this it would be easier to spot
The diff is big because I removed all the
executefolder. I know that this is lower priority so don't feel like you have to review straight away, it can wait :)