feat: pyarrow automated inference of format %Y%m%d%H%M%S
#1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdAbati
reviewed
Nov 6, 2024
MarcoGorelli
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
thanks for your PR (and @EdAbati + @FBruzzesi for reviews)
just got one really minor comment
regarding Polars, the datetime inference there is just based on trying out a bunch of hardcoded formats, and is probably ripe for being rewritten anyway
so i think we might as well go ahead with this
narwhals/_arrow/utils.py
Outdated
| HMS_RE = r"^(?P<hms>\d{2}:\d{2}:\d{2})$" | ||
| HM_RE = r"^(?P<hm>\d{2}:\d{2})$" | ||
| HMS_RE_NO_SEP = r"^(?P<hmsns>\d{6})$" |
There was a problem hiding this comment.
"ns" reads to me as "nanoseconds" here - maybe we can just write hms_no_sep?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.