Enh: adding automated inferencing of format %Y-%m-%dT%H:%M in pyarrow
#1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome! @FBruzzesi fancy taking a look if you have time? (not urgent of course) |
FBruzzesi
reviewed
Oct 31, 2024
narwhals/_arrow/utils.py
Outdated
Comment on lines
423
to
431
| format = "" | ||
| matches = pc.extract_regex(arr, pattern=HMS_RE) | ||
| if pc.all(matches.is_valid()).as_py(): | ||
| format = "%H:%M:%S" | ||
| else: | ||
| matches = pc.extract_regex(arr, pattern=HM_RE) | ||
| if pc.all(matches.is_valid()).as_py(): | ||
| format = "%H:%M" | ||
| return format |
There was a problem hiding this comment.
Opinionated take is to follow a similar pattern (pun unintended) as per date regex, i.e. having a format mapping:
TIME_FORMATS = (
(HMS_RE, "%H:%M:%S"),
(HM_RE, "%H:%M"),
)and here loop through that and have a early return for the first that fully matches, otherwise return empty string
There was a problem hiding this comment.
Thank you for the suggestion @FBruzzesi! I added a time formatting mapping similar to how it is done for dates, it looks much nicer now 🎉
Co-authored-by: Francesco Bruzzesi <[email protected]>
FBruzzesi
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.