-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more parameters to the fill_null method #1149
feat: add more parameters to the fill_null method #1149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you some much for the effort!
I think the only bits missing to pass the ci are:
- Testing the
ValueError
raise(s) - Silence the modin warning in pyproject.toml
Additionally I left a few comments in the code, leaning to the nitpick area π
I am tempted to say that coverage not showing may be an issue in |
Yeah, it was a bit strange, but I've already refactored the code to pass the coverage tests. Thanks for pointing it out! c: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton @IsaiasGutierrezCruz ! I am really happy to see this one!
When I will be back from vacation I may try to replicate the issue with coverage as well π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work, thanks @IsaiasGutierrezCruz (and @FBruzzesi for reviewing!)
I already resolved all the conversations π @MarcoGorelli |
thanks! there's a merge conflict, then i'll try to get this in |
Hi @MarcoGorelli , I hope you're doing well! Iβve implemented the last suggestion you provided some time ago. I just wanted to check in and see if there's anything else needed on my end for this pull request. Thanks for your time! |
thanks @IsaiasGutierrezCruz , and thanks @FBruzzesi for reviewing! sorry this took a while - very creative solution here for pyarrow, love it! π π |
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.