feat: allow format=None in str.to_datetime
#1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
reviewed
Oct 7, 2024
There was a problem hiding this comment.
thanks @FBruzzesi !
just a thought - it looks like here there's a pure-python solution to inferring a format
maybe, in plotly, they could do something like:
- if it's pandas-like or polars, use
to_datetimewithformat=None - else, take the first non-null element, get the format using the solution above, and try to parse using that?
just an idea - not a blocker for this pr anyway!
Shall we consider doing that in narwhals for pyarrow backend and null format? I think it can be a quite common use case for anything related with timeseries. |
|
yeah sure! |
|
Merging this one as is for now and will come back to the arrow dedicate branch in another PR |
akmalsoliev
pushed a commit
to akmalsoliev/narwhals
that referenced
this pull request
Oct 15, 2024
* WIP * allow str.to_datetime with format=None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Checklist
If you have comments or can explain your changes, please do so below.
Opening as draft since(Ok I misscliked) pyarrow is unsupported and may need some discussion for how to achieve it.For context, this is the snippet in plotly that requires casting to datetime: process_dataframe_timeline