remove unused kwargs for duckdb

narwhals-dev · Jan 27, 2025 · d782b75 · d782b75
1 parent f3814c8
commit d782b75
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 35 deletions.
diff --git a/narwhals/_duckdb/expr.py b/narwhals/_duckdb/expr.py
@@ -48,7 +48,6 @@ def __init__(
         returns_scalar: bool,
         backend_version: tuple[int, ...],
         version: Version,
-        kwargs: dict[str, Any],
     ) -> None:
         self._call = call
         self._depth = depth
@@ -58,7 +57,6 @@ def __init__(
         self._returns_scalar = returns_scalar
         self._backend_version = backend_version
         self._version = version
-        self._kwargs = kwargs
 
     def __call__(self: Self, df: DuckDBLazyFrame) -> Sequence[duckdb.Expression]:
         return self._call(df)
@@ -92,7 +90,6 @@ def func(_: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=False,
             backend_version=backend_version,
             version=version,
-            kwargs={},
         )
 
     @classmethod
@@ -116,7 +113,6 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=False,
             backend_version=backend_version,
             version=version,
-            kwargs={},
         )
 
     def _from_call(
@@ -147,7 +143,6 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=returns_scalar,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs=expressifiable_args,
         )
 
     def __and__(self: Self, other: DuckDBExpr) -> Self:
@@ -295,7 +290,6 @@ def alias_output_names(names: Sequence[str]) -> Sequence[str]:
             returns_scalar=self._returns_scalar,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={**self._kwargs, "name": name},
         )
 
     def abs(self: Self) -> Self:

diff --git a/narwhals/_duckdb/expr_name.py b/narwhals/_duckdb/expr_name.py
@@ -23,7 +23,6 @@ def keep(self: Self) -> DuckDBExpr:
             returns_scalar=self._compliant_expr._returns_scalar,
             backend_version=self._compliant_expr._backend_version,
             version=self._compliant_expr._version,
-            kwargs=self._compliant_expr._kwargs,
         )
 
     def map(self: Self, function: Callable[[str], str]) -> DuckDBExpr:
@@ -38,7 +37,6 @@ def map(self: Self, function: Callable[[str], str]) -> DuckDBExpr:
             returns_scalar=self._compliant_expr._returns_scalar,
             backend_version=self._compliant_expr._backend_version,
             version=self._compliant_expr._version,
-            kwargs={**self._compliant_expr._kwargs, "function": function},
         )
 
     def prefix(self: Self, prefix: str) -> DuckDBExpr:
@@ -53,7 +51,6 @@ def prefix(self: Self, prefix: str) -> DuckDBExpr:
             returns_scalar=self._compliant_expr._returns_scalar,
             backend_version=self._compliant_expr._backend_version,
             version=self._compliant_expr._version,
-            kwargs={**self._compliant_expr._kwargs, "prefix": prefix},
         )
 
     def suffix(self: Self, suffix: str) -> DuckDBExpr:
@@ -68,7 +65,6 @@ def suffix(self: Self, suffix: str) -> DuckDBExpr:
             returns_scalar=self._compliant_expr._returns_scalar,
             backend_version=self._compliant_expr._backend_version,
             version=self._compliant_expr._version,
-            kwargs={**self._compliant_expr._kwargs, "suffix": suffix},
         )
 
     def to_lowercase(self: Self) -> DuckDBExpr:
@@ -83,7 +79,6 @@ def to_lowercase(self: Self) -> DuckDBExpr:
             returns_scalar=self._compliant_expr._returns_scalar,
             backend_version=self._compliant_expr._backend_version,
             version=self._compliant_expr._version,
-            kwargs=self._compliant_expr._kwargs,
         )
 
     def to_uppercase(self: Self) -> DuckDBExpr:
@@ -98,5 +93,4 @@ def to_uppercase(self: Self) -> DuckDBExpr:
             returns_scalar=self._compliant_expr._returns_scalar,
             backend_version=self._compliant_expr._backend_version,
             version=self._compliant_expr._version,
-            kwargs=self._compliant_expr._kwargs,
         )
diff --git a/narwhals/_duckdb/namespace.py b/narwhals/_duckdb/namespace.py
@@ -58,7 +58,6 @@ def _all(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=False,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={},
         )
 
     def concat(
@@ -142,11 +141,6 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=False,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={
-                "exprs": exprs,
-                "separator": separator,
-                "ignore_nulls": ignore_nulls,
-            },
         )
 
     def all_horizontal(self: Self, *exprs: DuckDBExpr) -> DuckDBExpr:
@@ -163,7 +157,6 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=False,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={"exprs": exprs},
         )
 
     def any_horizontal(self: Self, *exprs: DuckDBExpr) -> DuckDBExpr:
@@ -180,7 +173,6 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=False,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={"exprs": exprs},
         )
 
     def max_horizontal(self: Self, *exprs: DuckDBExpr) -> DuckDBExpr:
@@ -197,7 +189,6 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=False,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={"exprs": exprs},
         )
 
     def min_horizontal(self: Self, *exprs: DuckDBExpr) -> DuckDBExpr:
@@ -214,7 +205,6 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=False,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={"exprs": exprs},
         )
 
     def sum_horizontal(self: Self, *exprs: DuckDBExpr) -> DuckDBExpr:
@@ -236,7 +226,6 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=False,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={"exprs": exprs},
         )
 
     def mean_horizontal(self: Self, *exprs: DuckDBExpr) -> DuckDBExpr:
@@ -261,7 +250,6 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=False,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={"exprs": exprs},
         )
 
     def when(
@@ -303,7 +291,6 @@ def func(_df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=True,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={},
         )
 
     def len(self: Self) -> DuckDBExpr:
@@ -319,7 +306,6 @@ def func(_df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             returns_scalar=True,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={},
         )
 
 
@@ -378,7 +364,6 @@ def then(self: Self, value: DuckDBExpr | Any) -> DuckDBThen:
             returns_scalar=self._returns_scalar,
             backend_version=self._backend_version,
             version=self._version,
-            kwargs={"value": value},
         )
 
 
@@ -394,7 +379,6 @@ def __init__(
         returns_scalar: bool,
         backend_version: tuple[int, ...],
         version: Version,
-        kwargs: dict[str, Any],
     ) -> None:
         self._backend_version = backend_version
         self._version = version
@@ -404,7 +388,6 @@ def __init__(
         self._evaluate_output_names = evaluate_output_names
         self._alias_output_names = alias_output_names
         self._returns_scalar = returns_scalar
-        self._kwargs = kwargs
 
     def otherwise(self: Self, value: DuckDBExpr | Any) -> DuckDBExpr:
         # type ignore because we are setting the `_call` attribute to a

diff --git a/narwhals/_duckdb/selectors.py b/narwhals/_duckdb/selectors.py
@@ -43,7 +43,6 @@ def evalute_output_names(df: DuckDBLazyFrame) -> Sequence[str]:
             backend_version=self._backend_version,
             returns_scalar=False,
             version=self._version,
-            kwargs={},
         )
 
     def numeric(self: Self) -> DuckDBSelector:
@@ -90,7 +89,6 @@ def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             backend_version=self._backend_version,
             returns_scalar=False,
             version=self._version,
-            kwargs={},
         )
 
 
@@ -112,7 +110,6 @@ def _to_expr(self: Self) -> DuckDBExpr:
             backend_version=self._backend_version,
             returns_scalar=self._returns_scalar,
             version=self._version,
-            kwargs={},
         )
 
     def __sub__(self: Self, other: DuckDBSelector | Any) -> DuckDBSelector | Any:
@@ -138,7 +135,6 @@ def evaluate_output_names(df: DuckDBLazyFrame) -> list[str]:
                 backend_version=self._backend_version,
                 returns_scalar=self._returns_scalar,
                 version=self._version,
-                kwargs={},
             )
         else:
             return self._to_expr() - other
@@ -170,7 +166,6 @@ def evaluate_output_names(df: DuckDBLazyFrame) -> list[str]:
                 backend_version=self._backend_version,
                 returns_scalar=self._returns_scalar,
                 version=self._version,
-                kwargs={},
             )
         else:
             return self._to_expr() | other
@@ -198,7 +193,6 @@ def evaluate_output_names(df: DuckDBLazyFrame) -> list[str]:
                 backend_version=self._backend_version,
                 returns_scalar=self._returns_scalar,
                 version=self._version,
-                kwargs={},
             )
         else:
             return self._to_expr() & other