Skip to content

Commit

Permalink
fix ibis
Browse files Browse the repository at this point in the history
  • Loading branch information
MarcoGorelli committed Sep 27, 2024
1 parent 676ad69 commit 36963f6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion narwhals/_ibis/dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def map_ibis_dtype_to_narwhals_dtype(
if ibis_dtype.is_timestamp():
return dtypes.Datetime()
if ibis_dtype.is_array():
return dtypes.Array()
return dtypes.List()
if ibis_dtype.is_struct():
return dtypes.Struct()
return dtypes.Unknown() # pragma: no cover
Expand Down
2 changes: 1 addition & 1 deletion tests/frame/schema_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def test_nested_dtypes_ibis() -> None: # pragma: no cover
)
tbl = ibis.memtable(df[["a", "c"]])
nwdf = nw.from_native(tbl)
assert nwdf.schema == {"a": nw.List, "c": nw.Struct}
assert nwdf.schema == {"a": nw.Array, "c": nw.Struct}


def test_nested_dtypes_dask() -> None:
Expand Down

0 comments on commit 36963f6

Please sign in to comment.