feat: allow selectors in drop and drop_nulls
#3897
FBruzzesirelease-drafter.yml
on: pull_request
update_release_draft
4s
Annotations
2 errors
|
update_release_draft
Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
{
name: 'HttpError',
id: '10409665531',
status: 422,
response: {
url: 'https://api.github.com/repos/narwhals-dev/narwhals/releases/170117319',
status: 422,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-length': '210',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 15 Aug 2024 19:53:35 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': '6407:1D1682:3A3666:6EF3E8:66BE5CBF',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4988',
'x-ratelimit-reset': '1723755212',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '12',
'x-xss-protection': '0'
},
data: {
message: 'Validation Failed',
errors: [
{
resource: 'Release',
code: 'invalid',
field: 'target_commitish'
}
],
documentation_url: 'https://docs.github.com/rest/releases/releases#update-a-release',
status: '422'
}
},
request: {
method: 'PATCH',
url: 'https://api.github.com/repos/narwhals-dev/narwhals/releases/170117319',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/20.13.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"body":"## Changes\\n\\n\\n\\nThank you to all our contributors for making this release possible!\\n@FBruzzesi and @MarcoGorelli\\n","draft":true,"prerelease":false,"make_latest":"true","name":"Narwhals v1.4.3","tag_name":"untagged-2dd5f30788f57820eda9","target_commitish":"refs/pull/789/merge"}',
request: {}
},
event: {
id: '10409665531',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '## What type of PR is this? (check all applicable)\r\n' +
'\r\n' +
'- [ ] 💾 Refactor\r\n' +
'- [x] ✨ Feature\r\n' +
'- [ ] 🐛 Bug Fix\r\n' +
'- [ ] 🔧 Optimization\r\n' +
'- [ ] 📝 Documentation\r\n' +
'- [ ] ✅ Test\r\n' +
'- [ ] 🐳 Other\r\n' +
'\r\n' +
'## Checklist\r\n' +
'\r\n' +
'- [x] Code follows style guide (ruff)\r\n' +
'- [x] Tests added \r\n' +
'- [ ] Documented the changes\r\n' +
'\r\n' +
'## If you have comments or can explain your changes, please do so below.\r\n' +
'\r\n' +
'Opening as draft because Dask is failing for selectors with the following error:\r\n' +
'\r\n' +
"> E KeyError: 'Cannot index with non-boolean dask Series. Try passing computed values instead (e.g. ``ddf.loc[iindexer.compute()]``)'\r\n" +
'\r\n' +
'and I am not sure if it is fixable 🙃'
}
},
number: 789,
organization: {
avatar_url: 'https://avatars.githubusercontent.com/u/169070048?v=4',
description: 'Narwhals developers',
events_url: 'https://api.github.com/orgs/narwhal
|
|
update_release_draft
HttpError: Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
at /home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:8462:21
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:30793:18)
{
name: 'AggregateError',
event: {
id: '10409665531',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '## What type of PR is this? (check all applicable)\r\n' +
'\r\n' +
'- [ ] 💾 Refactor\r\n' +
'- [x] ✨ Feature\r\n' +
'- [ ] 🐛 Bug Fix\r\n' +
'- [ ] 🔧 Optimization\r\n' +
'- [ ] 📝 Documentation\r\n' +
'- [ ] ✅ Test\r\n' +
'- [ ] 🐳 Other\r\n' +
'\r\n' +
'## Checklist\r\n' +
'\r\n' +
'- [x] Code follows style guide (ruff)\r\n' +
'- [x] Tests added \r\n' +
'- [ ] Documented the changes\r\n' +
'\r\n' +
'## If you have comments or can explain your changes, please do so below.\r\n' +
'\r\n' +
'Opening as draft because Dask is failing for selectors with the following error:\r\n' +
'\r\n' +
"> E KeyError: 'Cannot index with non-boolean dask Series. Try passing computed values instead (e.g. ``ddf.loc[iindexer.compute()]``)'\r\n" +
'\r\n' +
'and I am not sure if it is fixable 🙃'
}
},
number: 789,
organization: {
avatar_url: 'https://avatars.githubusercontent.com/u/169070048?v=4',
description: 'Narwhals developers',
events_url: 'https://api.github.com/orgs/narwhals-dev/events',
hooks_url: 'https://api.github.com/orgs/narwhals-dev/hooks',
id: 169070048,
issues_url: 'https://api.github.com/orgs/narwhals-dev/issues',
login: 'narwhals-dev',
members_url: 'https://api.github.com/orgs/narwhals-dev/members{/member}',
node_id: 'O_kgDOChPN4A',
public_members_url: 'https://api.github.com/orgs/narwhals-dev/public_members{/member}',
repos_url: 'https://api.github.com/orgs/narwhals-dev/repos',
url: 'https://api.github.com/orgs/narwhals-dev'
},
pull_request: {
_links: {
comments: {
href: 'https://api.github.com/repos/narwhals-dev/narwhals/issues/789/comments'
},
commits: {
href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/789/commits'
},
html: { href: 'https://github.com/narwhals-dev/narwhals/pull/789' },
issue: {
href: 'https://api.github.com/repos/narwhals-dev/narwhals/issues/789'
},
review_comment: {
href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/comments{/number}'
},
review_comments: {
href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/789/comments'
},
self: {
href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/789'
},
statuses: {
href: 'https://api.github.com/repos/narwhals-dev/narwhals/statuses/57fd09062b1da1d947b80a3ff20ff23a6c5e70c0'
}
},
active_lock_reason: null,
additions: 228,
assignee: null,
assignees: [],
author_association: 'MEMBER',
auto_merge: null,
base: {
label: 'narwhals-dev:main',
ref: 'main',
repo: {
allow_auto_merge: false,
allow_forking: true,
allow_merge_commit: false,
allow_rebase_merge: false,
allow_squash_merge: true,
allow_update_branch: false,
archive_url: 'https://api.github.com/repos/narwhals-dev/narwhals/{archive_format}{/ref}',
archived: false,
assignees_url
|