This repository has been archived by the owner on Feb 10, 2018. It is now read-only.
Add get_probes_config() and get_probes_results() #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can accept this hack: #7. What do you think? |
|
Can you enable the test in travis? You might have to rebase to include the hack. |
|
JunOS implementation for napalm-automation/napalm-base#9. Can be merged anytime (if not conflicts in .travis.yml) |
|
Check fails due to: napalm-automation/napalm-base#15 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not gonna work: I need to add the testers in .travis.yml but I cannot since the package napalm_base does not contain the tests base (even after merge).
Thus either after merge you need to create a new release of napalm_base 👎
Either in travis specify to clone napalm_base and install the develop version.