Skip to content
This repository has been archived by the owner on Feb 10, 2018. It is now read-only.

get_bgp_neighbors_detail emergency fix #164

Merged
merged 2 commits into from
Jun 8, 2017
Merged

get_bgp_neighbors_detail emergency fix #164

merged 2 commits into from
Jun 8, 2017

Conversation

mirceaulinic
Copy link
Member

The peer-fwd-rti has been introduced only in Junos 15

@coveralls
Copy link

coveralls commented Jun 7, 2017

Coverage Status

Coverage remained the same at 83.501% when pulling a4043ea on junos-15 into 12663f9 on develop.

@coveralls
Copy link

coveralls commented Jun 7, 2017

Coverage Status

Coverage remained the same at 83.501% when pulling a4043ea on junos-15 into 12663f9 on develop.

@dbarrosop
Copy link
Member

Is there a test for this already?

@mirceaulinic
Copy link
Member Author

Yes, there is: https://github.com/napalm-automation/napalm-junos/blob/develop/test/unit/mocked_data/test_get_bgp_neighbors_detail/normal/facts.yml
But the version in the facts is 12, while this bug affects junos 13 and 14 only.

@mirceaulinic mirceaulinic merged commit a9f979b into develop Jun 8, 2017
@dbarrosop
Copy link
Member

Yeah, that was kind of where I wanted to get at. We should add a case for junos 13 with mocked data that tests this is working there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants