This repository has been archived by the owner on Jan 16, 2019. It is now read-only.
Fix get_ntp_peers to comply with the changes in napalm-automation/napalm-base#12 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mirceaulinic @ktbyers could you take a look? |
|
I can just say that the code looks good, but the functional part is beyond my knowledges of Cisco output in terms of NTP. |
|
That's pretty much what I was aiming for. That I didn't did anything obviously wrong. The tests should cover pretty much the functional part. I will merge because this is the only module left. If @ktbyers things something is wrong we can fix it later on. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix get_ntp_peers to comply with the changes in napalm-automation/napalm-base#12