-
Notifications
You must be signed in to change notification settings - Fork 48
Add get_ntp_peers() #13
Add get_ntp_peers() #13
Conversation
@dbarrosop, @ktbyers does |
|
||
Example:: | ||
|
||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do a dictionary instead? Right now it's going to be a bit sad because it's going to be a dictionary with no values:
{
'192.168.0.1': {}
'17.72.148.53': {}
'37.187.56.220': {}
'162.158.20.18': {}
}
The reason is that you can stil do d.get_ntp_peers.keys()
to get the list but doing a dict of dicts will allow us to extend this method to add more data if needed. Like the key used for authentication, or other configuration parameters. What do you think?
Although for the moment I don't see an obvious need, it is possible to need more information around NTP peers. Moreover would not cost very much to transform it into a dictionary. |
@dbarrosop I finished updating the drivers, everything should be fine now. |
@dbarrosop all clear now :) |
As discussed in #12, will reimplement get_ntp_peers() to return a list of NTP peers as configured on the device.