-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: handle failed attempts with error message, icon color and description. #163
Conversation
…olor and sensorErrorDescription options. Update dialog UI and README.
This is really interesting - thanks for the PR. I'll review and think about how best to integrate since this changes the flow for existing users. |
This is great. Hope this comes in soon |
@zibs I understand, thanks for taking the time to review it. @ronilitman glad you find it useful, hopefully it'll get merged. |
What do you all think of #165 ? It seems like it might be a good time to migrate to what will become the conventional UI for android? |
Nice, this is pretty awesome. I'll merge it in. |
@srulfi Thanks for those changes, this is very helpful!
|
also, having this issue, not sure this is related to this PR: |
@ronilitman the issue you mentioned seems to be reproducible on iOS and the significant files this PR modified where all on Android side. For what it's worth I'm not able to reproduce the issue you described. Tested it only on the simulator. Let me know if I can help you troubleshooting it. Regarding the 2 things you listed:
|
My issue with this change currently, and I don't know how it was before, is that even though it disables the sensor after 5 attempts, there is no trigger for us to do anything on failure of those 5 attempts. Or am I missing something |
Is there is any possibility to increase attempts to more than 5? Or can be any callback that invokes after 5 attempts? |
Issue discussed 156, 81, 92, 107
Updated UI:

Updated config object:
color
forimageColor
imageErrorColor
(default: "#ff0000")sensorErrorDescription
(default: "Failed")