Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable ep url sock send recv #2070

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Stable ep url sock send recv #2070

merged 2 commits into from
Jan 5, 2025

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Jan 5, 2025

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

These are the 2.0 equivalent versions of nng_send_aio and nng_recv_aio.
The old names are preserved as aliases for the new.  Applications can
start adopting these with this release, even before 2.0 is ready.
…_get_url

This is meant to help applications start adopting new interfaces before converting to NNG 2.0
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 27.27273% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (73dbf23) to head (561fc87).
Report is 3 commits behind head on stable.

Files with missing lines Patch % Lines
src/nng.c 33.33% 12 Missing ⚠️
src/core/dialer.c 0.00% 2 Missing ⚠️
src/core/listener.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           stable    #2070      +/-   ##
==========================================
+ Coverage   79.37%   79.59%   +0.21%     
==========================================
  Files          95       95              
  Lines       21721    21741      +20     
==========================================
+ Hits        17242    17304      +62     
+ Misses       4479     4437      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 561fc87 into stable Jan 5, 2025
14 of 16 checks passed
@gdamore gdamore deleted the stable-ep-url-sock-send-recv branch January 5, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant