Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP: intern the version and avoid allocation #2005

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 22, 2024

There are only a few possible reasonable values, and we can intern them to avoid any allocations for it. (We will probably do the same for the HTTP method shortly as well.)

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

There are only a few possible reasonable values, and we can intern
them to avoid any allocations for it.  (We will probably do the same
for the HTTP method shortly as well.)
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.03%. Comparing base (fc6c4e1) to head (9ac2c5a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/supplemental/http/http_msg.c 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
- Coverage   82.06%   82.03%   -0.04%     
==========================================
  Files          95       95              
  Lines       23947    23948       +1     
  Branches     3153     3153              
==========================================
- Hits        19653    19646       -7     
- Misses       4220     4229       +9     
+ Partials       74       73       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 9ac2c5a into main Dec 22, 2024
36 of 37 checks passed
@gdamore gdamore deleted the http-intern-version branch December 22, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant