Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket inline #1992

Merged
merged 2 commits into from
Dec 16, 2024

transports: all transports use the new inline approach

ab460d5
Select commit
Loading
Failed to load commit list.
Merged

Websocket inline #1992

transports: all transports use the new inline approach
ab460d5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 16, 2024 in 0s

81.91% (-0.09%) compared to 58df588

View this Pull Request on Codecov

81.91% (-0.09%) compared to 58df588

Details

Codecov Report

Attention: Patch coverage is 95.23810% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.91%. Comparing base (58df588) to head (ab460d5).

Files with missing lines Patch % Lines
src/sp/transport/ws/websocket.c 92.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1992      +/-   ##
==========================================
- Coverage   82.00%   81.91%   -0.09%     
==========================================
  Files          95       95              
  Lines       24124    24027      -97     
  Branches     3181     3165      -16     
==========================================
- Hits        19782    19682     -100     
- Misses       4269     4274       +5     
+ Partials       73       71       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov