Aio reap noreschedule #1966
Merged
Aio reap noreschedule #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdamore
force-pushed
the
aio-reap-noreschedule
branch
from
dedfd30 to
bc5b5e2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1966 +/- ##
==========================================
+ Coverage 81.78% 81.88% +0.09%
==========================================
Files 95 95
Lines 24022 24065 +43
Branches 3200 3208 +8
==========================================
+ Hits 19646 19705 +59
+ Misses 4303 4286 -17
- Partials 73 74 +1 ☔ View full report in Codecov by Sentry. |
We do not want to let operations restart if we're in the process of shutting down. This ensures that they get a reasonable hard failure.
Probably other subsystems should get the same treatment. We need to basically start the process of shutting down so that subsystems know to cease operation before we rip memory out from underneath them. This ensures that no new operations can be started as well, once we have begun the process of teardown. We also enhanced the completion of sleep to avoid some extra locking contention, since the expiration *is* the completion. Includes a test for this case.
gdamore
force-pushed
the
aio-reap-noreschedule
branch
from
bc5b5e2 to
8fa3b2a
Compare
Make sure *everything* is drained before proceeding all the way to deallocation.
gdamore
force-pushed
the
aio-reap-noreschedule
branch
from
b341255 to
71e459e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #
Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.