Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1408 Reference count as a first class type #1963

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 7, 2024

This starts by using this for the nni_pipe, but we will use it for the other primary objects as well. This should simplify the tear down and hopefully eliminate some races.

It does mean that pipe destruction goes through an additional context switch, for now at least. This shouldn't be on the hot data path anyway.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

This starts by using this for the nni_pipe, but we will use it
for the other primary objects as well.  This should simplify
the tear down and hopefully eliminate some races.

It does mean that pipe destruction goes through an additional
context switch, for now at least.  This shouldn't be on the hot
data path anyway.
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (513f9d1) to head (755dcb2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   81.75%   81.93%   +0.18%     
==========================================
  Files          94       95       +1     
  Lines       24015    24022       +7     
  Branches     3202     3200       -2     
==========================================
+ Hits        19633    19683      +50     
+ Misses       4311     4265      -46     
- Partials       71       74       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 755dcb2 into main Dec 7, 2024
17 of 19 checks passed
@gdamore gdamore deleted the pipe-refcnt branch December 7, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant