Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nng url no alloc #1937

Merged
merged 3 commits into from
Nov 18, 2024

URL refactor part 1.

ca6cfe3
Select commit
Loading
Failed to load commit list.
Merged

Nng url no alloc #1937

URL refactor part 1.
ca6cfe3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 18, 2024 in 0s

80.89% (-0.41%) compared to 85aff44

View this Pull Request on Codecov

80.89% (-0.41%) compared to 85aff44

Details

Codecov Report

Attention: Patch coverage is 84.44444% with 21 lines in your changes missing coverage. Please review.

Project coverage is 80.89%. Comparing base (85aff44) to head (ca6cfe3).

Files with missing lines Patch % Lines
src/core/url.c 86.23% 15 Missing ⚠️
src/supplemental/http/http_msg.c 75.00% 3 Missing ⚠️
src/nng.c 0.00% 2 Missing ⚠️
src/core/listener.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1937      +/-   ##
==========================================
- Coverage   81.30%   80.89%   -0.41%     
==========================================
  Files          94       94              
  Lines       23946    23951       +5     
  Branches     3189     3187       -2     
==========================================
- Hits        19469    19376      -93     
- Misses       4406     4502      +96     
- Partials       71       73       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: