Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp/tls: Remove support for local interface address in dialer URLs #1934

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 17, 2024

This was an undocumented capability provided for libnanomsg. The correct way to obtain the same functionality is to use NNG_OPT_LOCADDR.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

This was an undocumented capability provided for libnanomsg.  The
correct way to obtain the same functionality is to use `NNG_OPT_LOCADDR`.
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (48d0c03) to head (ff66ec5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
- Coverage   81.18%   80.98%   -0.20%     
==========================================
  Files          94       94              
  Lines       24032    23956      -76     
  Branches     3208     3192      -16     
==========================================
- Hits        19510    19401     -109     
- Misses       4448     4482      +34     
+ Partials       74       73       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit ff66ec5 into main Nov 17, 2024
18 of 19 checks passed
@gdamore gdamore deleted the no-local-addr-url branch December 31, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant