Gdamore/udp burst tune #1916
Merged
Gdamore/udp burst tune #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't emit the log for date change unless we are in debug mode. Emit a newline when starting a new NUTS test. Change the default log level - it was too noisy.
The burst test should be more reliable (by avoiding extra work during the hot code path). We also make the threshold for pass/failure tunable via an environment variable (NNG_UDP_PASS_RATE) which is a percentage.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1916 +/- ##
==========================================
- Coverage 80.17% 80.04% -0.13%
==========================================
Files 94 94
Lines 24073 24073
Branches 3239 3239
==========================================
- Hits 19301 19270 -31
- Misses 4698 4730 +32
+ Partials 74 73 -1 ☔ View full report in Codecov by Sentry. |
This seems to give much higher reliability in message receives, so we've tightened it up a bit for now.
gdamore
force-pushed
the
gdamore/udp-burst-tune
branch
from
b25d659 to
75eb6f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #
Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.