Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket option handling clean ups for endpoints. #1912

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 3, 2024

The framework for saving and replaying socket options was left over, and should not be used. But we do need to send the initial socket options to endpoints when creating them, so we have support for that in a cleaner fashion that does not require memory allocations.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

The framework for saving and replaying socket options was left
over, and should not be used.  But we do need to send the initial
socket options to endpoints when creating them, so we have support
for that in a cleaner fashion that does not require memory allocations.
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.50%. Comparing base (4907623) to head (ae6cd21).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/socket.c 88.57% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
+ Coverage   80.25%   80.50%   +0.24%     
==========================================
  Files          94       94              
  Lines       24129    24073      -56     
  Branches     3253     3239      -14     
==========================================
+ Hits        19365    19379      +14     
+ Misses       4689     4622      -67     
+ Partials       75       72       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit ae6cd21 into main Nov 3, 2024
16 of 17 checks passed
@gdamore gdamore deleted the gdamore/no-socket-save-options branch November 3, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant