Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NNG_OPT_SUB_SUBSCRIBE/UNSUBSCRIBE with functions. #1909

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 3, 2024

The main purpose is to eliminate the NNI_TYPE_OPAQUE options, by putting these into their own first class, protocol-specific, functions.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

The main purpose is to eliminate the NNI_TYPE_OPAQUE options,
by putting these into their own first class, protocol-specific, functions.
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.02%. Comparing base (02ec0b5) to head (a5807e4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/tools/perf/pubdrop.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1909      +/-   ##
==========================================
- Coverage   80.14%   80.02%   -0.12%     
==========================================
  Files          94       94              
  Lines       24232    24275      +43     
  Branches     3251     3259       +8     
==========================================
+ Hits        19420    19426       +6     
- Misses       4738     4777      +39     
+ Partials       74       72       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore force-pushed the gdamore/sub-option branch from 8911edd to a5807e4 Compare November 3, 2024 09:26
@gdamore gdamore merged commit a5807e4 into main Nov 3, 2024
16 of 17 checks passed
@gdamore gdamore deleted the gdamore/sub-option branch November 3, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant