Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aio test failures on darwin #1884

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix aio test failures on darwin #1884

merged 1 commit into from
Oct 7, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Oct 7, 2024

Actually this test appears to be broken everywhere, and the only reason it ever worked is that we took > 50 ms to context switch.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Actually this test appears to be broken everywhere, and the only
reason it ever worked is that we took > 50 ms to context switch.
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.21%. Comparing base (2592bfc) to head (1a4d71c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1884      +/-   ##
==========================================
- Coverage   77.23%   77.21%   -0.02%     
==========================================
  Files          95       95              
  Lines       22286    22286              
==========================================
- Hits        17213    17209       -4     
- Misses       5073     5077       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 1a4d71c into main Oct 7, 2024
14 of 16 checks passed
@gdamore gdamore deleted the gdamore/fix-aio-test branch October 7, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant