Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdamore/udp #1879

Merged
merged 6 commits into from
Oct 6, 2024
Merged

Gdamore/udp #1879

merged 6 commits into from
Oct 6, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Oct 6, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

This will be used in UDP.  It also lets us reduce some unnecessary
code paths for redundant library initialization.
This adds endian awareness at compile time, and defines some little
endian versions of some macros. We antiicpate making more use of
little endian in new protocols to reduce the "endian tax", as nearly
every modern system is little endian these days.
This will be used for some follow up work (UDP).
This is expected to be useful for new transports where we need
the sock address to properly reply (think UDP with multicast).
This is the initial implementation of UDP transport.
It does in order guarantees (and consequently filters duplicates),
but it does not guarantee delivery.  The protocol limits payloads
to 65000 bytes (minus headers for SP), but you really want to
keep it to much less -- probably best for short messages that within
a single MTU to avoid IP fragmentation and reassembly.

This is unicast only for now (although there are plans for some
support for multicast and broadcast as well as being able to
perform automatic mesh building, but that will be in following work.

Additional tunables are coming.  This is only lightly tested at
this point, and should be considered experimental.  Its also undocumented.
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.71%. Comparing base (29aff2b) to head (07a0155).

Files with missing lines Patch % Lines
src/core/message.c 0.00% 4 Missing ⚠️
src/core/idhash.c 0.00% 2 Missing ⚠️
src/core/url.c 87.50% 2 Missing ⚠️
src/core/tcp.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1879      +/-   ##
==========================================
+ Coverage   79.70%   79.71%   +0.01%     
==========================================
  Files          95       95              
  Lines       21629    21636       +7     
==========================================
+ Hits        17240    17248       +8     
+ Misses       4389     4388       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 07a0155 into master Oct 6, 2024
16 of 18 checks passed
@gdamore gdamore deleted the gdamore/udp branch December 31, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant