Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nng_msg_clear also clears the header #1252

Closed
jeikabu opened this issue Jun 7, 2020 · 0 comments · Fixed by #1257
Closed

nng_msg_clear also clears the header #1252

jeikabu opened this issue Jun 7, 2020 · 0 comments · Fixed by #1257

Comments

@jeikabu
Copy link
Contributor

jeikabu commented Jun 7, 2020 •
edited
Loading

nng_msg_clear docs state that it only clears the message body, but in 1.3.0 it clears both the body and header. This was not the case in earlier releases.

NNG & Platform details.

1.3.0

Expected Behavior

nng_msg_clear only clears the message body and leaves the header untouched.

Actual Behavior

nni_msg_clear now also clears the now inlined header from this CL (abab139#diff-f719e7b45a41a7b3f01eea3660f52434).
@jeikabu jeikabu mentioned this issue Jun 7, 2020
Closed
jeikabu added a commit to jeikabu/nng that referenced this issue Jun 16, 2020
@jeikabu
fix nanomsg#1252
2582466 
- nng_msg_clear should only clear the message body and not the head.  Add test to verify
@jeikabu jeikabu mentioned this issue Jun 16, 2020
Merged
gdamore pushed a commit that referenced this issue Jun 16, 2020
@jeikabu @gdamore
fix #1252
b12081b 
- nng_msg_clear should only clear the message body and not the head.  Add test to verify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #1252 jeikabu/nng
1 participant
@jeikabu